docs: Disallow decimal literals with trailing dots #13191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the documentation suggests that a decimal literal can omit the fractional part [1]: > Decimal fractional literals are formed by a `.` with at least one > number on one side. Examples include `1.`, `.1` and `1.3`. However, commit ac68710 (May 30, 2018) disallowed trailing dots that are not followed by a number [2]. Using decimal literals of the form `1.` will actually result in a `ParserError` and so the docs should no longer recommend this form. [1] https://docs.soliditylang.org/en/v0.8.15/types.html#rational-and-integer-literals [2] argotorg@ac68710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the documentation suggests that a decimal literal can omit the fractional part [1]:
However, commit ac68710 (May 30, 2018) disallowed trailing dots that are not followed by a number [2].
Using decimal literals of the form
1.will actually result in aParserErrorand so the docs should not recommend this form.[1] https://docs.soliditylang.org/en/v0.8.15/types.html#rational-and-integer-literals
[2] ac68710