eof: Fix constructor argument copying for EOF #15637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
78146e5 to
ab2af67
Compare
ab2af67 to
1ca4f78
Compare
cameel
requested changes
Dec 12, 2024
test/libsolidity/semanticTests/constructor/base_constructor_arguments.sol
Show resolved
Hide resolved
1ca4f78 to
bc02eb0
Compare
cameel
reviewed
Dec 13, 2024
There was a problem hiding this comment.
There are still a few things to fix regarding passing an EOF version.
But like I said on the chat, I'd actually be fine doing it the way you did initially (passing EOF version in a parameter) and only refactoring in a separate PR so that we can get this one merged quicker.
7fe1be7 to
74dd020
Compare
cameel
reviewed
Dec 18, 2024
Comment on lines
+1505
to
+1510
| std::shared_ptr<Compiler> compiler = std::make_shared<Compiler>( | ||
| m_evmVersion, | ||
| m_eofVersion, | ||
| m_revertStrings, | ||
| m_optimiserSettings | ||
| ); |
There was a problem hiding this comment.
Compiler and CompilerContext are the two places where it's ok to hard-code nullopt for EOF version. They do use ABIFunctions and YulUtilFunctions but only in legacy context.
On the other hand it's not wrong, just unnecessary so I think we can leave it at that and just merge the PR.
cameel
approved these changes
Dec 18, 2024
74dd020 to
b1d3143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract constructor argument copying needs specific handling for EOF.
Depends on #15635.Merged.