Simplify ConstantEvaluator. #3232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
commented
Nov 22, 2017
| } | ||
| )"; | ||
| CHECK_ERROR(text, TypeError, "Identifier must be declared constant."); | ||
| CHECK_ERROR(text, TypeError, "Invalid array length, expected integer literal or constant expression."); |
There was a problem hiding this comment.
We lose a little precision here, but I think the previous error message was not particularly helpful, because you actually cannot declare a constant.
|
I'd split this into:
|
chriseth
commented
Nov 22, 2017
| } | ||
| } | ||
| )"; | ||
| CHECK_ERROR(text, TypeError, "Constant identifier declaration must have a constant value."); |
There was a problem hiding this comment.
This error message is also not too helpful, because you cannot assign a constant value to this variable.
axic
reviewed
Nov 22, 2017
| _operation, | ||
| Token::isCompareOp(_operation.getOperator()) ? | ||
| make_shared<BoolType>() : | ||
| left->binaryOperatorResult(_operation.getOperator(), right) |
There was a problem hiding this comment.
Why not keep using commonType here?
|
@axic I don't think I have time to work on splitting this... |
1ec1135 to
e39da3b
Compare
e39da3b to
48c7ba7
Compare
axic
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was increasingly uneasy with ConstantEvaluator setting the
typeproperty of the annotations. This should only be done by the TypeChecker, and not already in the reference resolution stage.