Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Travis Testing against Octave #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 15, 2015
Merged

Conversation

blink1073
Copy link
Collaborator

Closes #138.
Tests in 2.7 and 3.3 using Miniconda environments.
The 3.4 test was hanging at the end, but does not hang on my Ubuntu 14.04 install, so I removed it.
Current coverage is 80%. I'll add some more tests in another PR.

@isbadawi
Copy link
Collaborator

Some notes as you're working on this -- I did go through a bit of this before:

  • I would use ppa:octave/stable instead of ppa:picaso/octave. The latter is only on 3.6.1 -- IIRC Java support became builtin only in Octave 3.8 (before that it was a separate package). That's also why you get the error about --no-gui.
  • The magic tests still use Matlab even if USE_OCTAVE=1. Either exclude them or fix the magic to support Octave too

@blink1073
Copy link
Collaborator Author

Thanks!

@blink1073
Copy link
Collaborator Author

By the way @isbadawi, Octave magic is now working 😄

Update travis script to run test suite

Update travis script to actually do testing

Install zmq

Install pyzmq

Remove doctesting

Remove unsupported --no-gui option in Octave

Attempt to spoof javaclasspath

Attempt to spoof javaclasspath

Use newer Octave

Try an explicit java install
Use gnuplot so figures are created properly

Add support for octave magic in test
Avoid short-circuit operator for Octave compatibility

Install scipy

Add base64 handling

Clean up and use get_ipython

Clean up, do no require scipy, and do not close matlab twice

Do not require scipy

Prevent file resource warnings

Avoid deprecationwarning
Update installation instructions

Move to a platform-indepented octave makefile

Do not test on Py3.4 due to bug in importlib causing hangup

Try python 3.4 again without warnings

Fix travis syntax error

Add debug output in travis

Do not install scipy in travis

Remove py3.4 build to to hanging

Remove redundant conda info
@blink1073
Copy link
Collaborator Author

Ready to roll!

@isbadawi
Copy link
Collaborator

Looks good overall, but I'm not sure I like the Octave and Ubuntu specific make.py you added. I think it would be better to generalize the other make.py so that it can build the Octave messenger if needed. I also feel like installing system dependencies shouldn't be make.py's responsibility.

We can address that later though -- getting tests to run on Travis is more important. Thanks for working on this!

isbadawi added a commit that referenced this pull request Feb 15, 2015
Add Travis Testing against Octave
@isbadawi isbadawi merged commit 211ab13 into arokem:master Feb 15, 2015
@blink1073
Copy link
Collaborator Author

I agree it is a bit of a hack, my plan was to get it working on Windows next and devise a more general solution. I do not have access to a Mac. I agree the apt-get belongs in the documentation as opposed to the make file.

@arokem
Copy link
Owner

arokem commented Feb 15, 2015

First of all, this is great.

Second - this Octave thing now doesn't work on my machine (a mac), because
of that apt-get. If this is just for travis, can't we move the apt-get into
the .travis.yml file, and then set up whether you use the matlab for mex
generation or octave with mkoctfile through the local.cfg file?

On Sun, Feb 15, 2015 at 7:57 AM, Steven Silvester [email protected]
wrote:

I agree it is a bit of a hack, my plan was to get it working on Windows
next and devise a more general solution. I do not have access to a Mac. I
agree the apt-get belongs in the documentation as opposed to the make file.


Reply to this email directly or view it on GitHub
#139 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double scalars not handled by Octave
3 participants