Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Streamline mex build and install process #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 16, 2015
Merged

Streamline mex build and install process #140

merged 19 commits into from
Feb 16, 2015

Conversation

blink1073
Copy link
Collaborator

Unfortunately, I could not get it working in Windows: http://savannah.gnu.org/bugs/?41833. See my comment below for the gory details.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling 072fe8d on blink1073:master into d1e1988 on arokem:master.

@isbadawi
Copy link
Collaborator

Hmm. I'm going to turn off these comments from coveralls -- the info is there in the status box with the Travis status.

isbadawi
isbadawi reviewed Feb 16, 2015
View reviewed changes
setup.py
import os
import sys
import shutil
import glob
from distutils.core import setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment below says distutils was imported later on purpose. (I'm not really familiar with why though).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see (I guess), I'll move it.

@isbadawi
Copy link
Collaborator

Looks good overall. I built the Octave messenger on my mac and it worked fine. The Windows thing I guess is an upstream problem?

I'm OK with merging this after you address the (tiny) comments I made.

I just tried it out and the Octave and MATLAB mex files apparently can coexist in the same directory, and each program will pick up the right one. At this point we could start including pre-built binaries for Octave too.

@blink1073
Copy link
Collaborator Author

Wow, what a nightmare on Windows:
I have been unable to get Java installed on any of the four versions:
3.8.1 MXE:

octave:1> setenv("JAVA_HOME", "C:/Program Files/Java/jdk1.8.0_31/")
octave:2> javaObject
error: unable to find Java Runtime Environment: software\javasoft\java runtime environment::Currentversion

3.6.4 Visual Studio:

octave-3.6.4.exe:1> setenv("JAVA_HOME", "C:/Program Files/java/jdk1.8.0_31")
octave-3.6.4.exe:2> pkg install -forge java
configure: error: in `/c/Users/SILVES~1/AppData/Local/Temp/oct-2/java/src':
configure: error: C compiler cannot create executables
See `config.log' for more details.
the configure script returned the following error: checking for gcc... cc-msvc
checking whether the C compiler works... no
error: called from 'pkg>configure_make' in file C:\Software\Octave-3.6.4\share\o
ctave\3.6.4\m\pkg\pkg.m near line 1373, column 9
error: called from:
error:   C:\Software\Octave-3.6.4\share\octave\3.6.4\m\pkg\pkg.m at line 827, co
lumn 5
error:   C:\Software\Octave-3.6.4\share\octave\3.6.4\m\pkg\pkg.m at line 383, co
lumn 9

3.6.4 Mingw:

octave:1> setenv("JAVA_HOME", "C:/Program Files/java/jdk1.8.0_31/")
octave:2> pkg install -forge java
./configure: line 3257: test: too many arguments
configure: WARNING: this package requires at least Java-1.5
For information about changes from previous versions of the java package, run 'n
ews ("java")'.

Cygwin 3.8.2:

octave:1> setenv("JAVA_HOME", "C:/Program Files/java/jdk1.8.0_31")
octave:2> pkg install -forge java
pkg: unable to find the mkoctfile command, Octave installation is incomplete
error: called from '__gripe_missing_component__' in file /usr/share/octave/3.8.2/m/help/__gripe_missing_component__.m near line 53, column 3
error: called from:
error:   /usr/share/octave/3.8.2/m/pkg/private/install.m at line 199, column 5
error:   /usr/share/octave/3.8.2/m/pkg/pkg.m at line 394, column 9

I tried installing the octave-devel Cygwin package, but it is version 3.8.1 and not compatible, yay!

@blink1073
Copy link
Collaborator Author

I was hoping to phase out Oct2Py, but I don't see that happening until a proper 3.8 release with Java support is available on Windows.

@blink1073
Copy link
Collaborator Author

@isbadawi, ready to roll!

isbadawi added a commit that referenced this pull request Feb 16, 2015
@isbadawi
Merge pull request #140 from blink1073/master
553c425 
Streamline mex build and install process
@isbadawi isbadawi merged commit 553c425 into arokem:master Feb 16, 2015
isbadawi added a commit to Sable/mclab-ide that referenced this pull request Feb 16, 2015
@isbadawi
Simplify Vagrantfile & manual install instructions
ff42353 
As of arokem/python-matlab-bridge#140, a pre-built messenger.mex is
included for Octave on Linux.
@arokem
Copy link
Owner

arokem commented Feb 16, 2015

Nice job. There was one small thing left over from this. See:
#141

On Mon, Feb 16, 2015 at 8:37 AM, Ismail Badawi [email protected]
wrote:

Merged #140 #140.

—
Reply to this email directly or view it on GitHub
#140 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blink1073 @coveralls @isbadawi @arokem