fix messenger build on windows #161
Conversation
|
Thanks for doing this! I think that the test breakage is fixed here: So let's merge that one first, and then rebase this one on top of it, before merging it as well. |
| else: | ||
| print(usage) | ||
| build_octave() |
There was a problem hiding this comment.
This seems like it might be confusing. If someone enters a typo, it will try to build the octave thing and emit a confusing error. How about:
elif args.target == 'octave':
build_octave
else:
e_s = "'%s' is not a valid target for building the messenger."%args.target
e_s = e_s + " Use 'matlab' or 'octave'"
raise ValueError(e_s)
Or something to that effect. Also, could you please rebase on master? Thanks!
There was a problem hiding this comment.
It won't let you choose another one because argparse limits the choices.
for example, running ./make.py foo will give:
usage: make.py [-h] [--static] {matlab,octave}
make.py: error: argument target: invalid choice: 'foo' (choose from
'matlab', 'octave')
On Mon, Mar 9, 2015 at 7:54 PM, Ariel Rokem [email protected]
wrote:
In messenger/make.py
#161 (comment)
:else:
print(usage)build_octave()This seems like it might be confusing. If someone enters a typo, it will
try to build the octave thing and emit a confusing error. How about:elif args.target == 'octave':
build_octave
else:
e_s = "'%s' is not a valid target for building the messenger."%args.target
e_s = e_s + " Use 'matlab' or 'octave'"
raise ValueError(e_s)Or something to that effect. Also, could you please rebase on master?
Thanks!—
Reply to this email directly or view it on GitHub
https://github.com/arokem/python-matlab-bridge/pull/161/files#r26095797.
There was a problem hiding this comment.
I'll still change it though... it is your repo after all :)
On Mon, Mar 9, 2015 at 8:01 PM, Ali Ebrahim [email protected] wrote:
It won't let you choose another one because argparse limits the choices.
for example, running ./make.py foo will give:
usage: make.py [-h] [--static] {matlab,octave}
make.py: error: argument target: invalid choice: 'foo' (choose from
'matlab', 'octave')On Mon, Mar 9, 2015 at 7:54 PM, Ariel Rokem [email protected]
wrote:In messenger/make.py
#161 (comment)
:else:
print(usage)build_octave()This seems like it might be confusing. If someone enters a typo, it will
try to build the octave thing and emit a confusing error. How about:elif args.target == 'octave':
build_octave
else:
e_s = "'%s' is not a valid target for building the messenger."%args.target
e_s = e_s + " Use 'matlab' or 'octave'"
raise ValueError(e_s)Or something to that effect. Also, could you please rebase on master?
Thanks!—
Reply to this email directly or view it on GitHub
https://github.com/arokem/python-matlab-bridge/pull/161/files#r26095797
.
There was a problem hiding this comment.
Gotcha. No need to change - I just really didn't know how that works. I see the whole thing above now. Cool. Thanks for doing this - much cleaner.
This commit also includs an updated messenger mex for windows 64 bit which is statically linked against libzmq 4.0.5 (so it does not need to be separately installed). The make.py script for messenger has been updated to use argparse, and also now supports linking to a statically linked zmq.
|
Should be good to go |
|
Thanks! |
No description provided.