Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixes related to R2007b #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2012
Merged

fixes related to R2007b #2

merged 2 commits into from
Dec 21, 2012

Conversation

shabbychef
Copy link
Contributor

I believe I have this code running on R2007b now; fixing two problems

  1. old Matlab java dispatch problems (static constructor followed by function call was disallowed),
  2. (possibly unrelated) out-of-bounds error on header parsing.

in r2007b, I get
      Static method or constructor invocations cannot be indexed.
      Do not follow the call to the static method or constructor with
      any additional indexing or dot references.
when calling the code as-was; fixed by creating a temporary variable.
I am not sure if this is an 'old Matlab' problem or an issue of
using a non-standard browser for HTTP requests, but I was getting
out-of-bound errors when trying to set the header.Get.Protocol field.

I cannot find any place in the codebase that even *uses* the .Protocol,
but perhaps a better default should be filled in.
@arokem
Copy link
Owner

arokem commented Dec 21, 2012

Looks good. Thanks a lot for doing this!

arokem added a commit that referenced this pull request Dec 21, 2012
@arokem arokem merged commit aa22364 into arokem:master Dec 21, 2012
haoxingz added a commit that referenced this pull request Feb 3, 2014
BF: Make inputs and outputs from the magic conform in shape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants