Update with nbformat #222
Merged
Update with nbformat #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've changed the imports (two) in publish.py from IPython.nbformat to nbformat. I'm concerned that this breaks backwards compatibility though. I'm not sure how to assure that if nbformat doesn't exist, Python.nbformat will be.
if nbformat exists as a package, import it instead of the legacy named Python.nbformat . Corrects error thrown by Jupyter.
modify the python3.4 env variable so nbformat isn't added for older versions of python. I'm guessing at this point.
I have no idea how to fix this so travis can build it. My other changes seem to work, just not in travis.
659240b to
d98c05c
Compare
|
Oh, we are almost there! Installing nbformat on python 3.3 seems like a problem. I've asked on the jupyter list for advice to move forward here. |
|
OK - this is coming up green now. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #213, but updated with recent master