Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clean up messenger handling #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Clean up messenger handling #266

merged 2 commits into from
Sep 30, 2021

Conversation

ovidner
Copy link
Collaborator

@ovidner ovidner commented Sep 29, 2021

The main feature of this pull request is that it changes the messenger architecture to be detected at runtime instead of at setup. This makes it easier to package the project and makes it possible to remove some of the hacks from setup.py. It also fixes an issue with some users not having the correct messenger files installed (see e.g. #220 (comment)).

@arokem arokem merged commit 51c0e79 into arokem:master Sep 30, 2021
@arokem
Copy link
Owner

arokem commented Sep 30, 2021

Yeah - thanks! This does look cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants