Remove assert that check that signal/filter types have to be the same #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the check that ensures that the filter type and signal type have to be the same.
Description
The filter and signal type need to be the same to function properly but ArrayFire used to perform implicit conversions if the filter type does not match the signal type. A check was added in the previous release that added an assert to enforce the same type which broke some code. This PR removes that check.
This sort of thing should warn the user in case this is being performed. We can also add a flag that does perform these checks for users who are concerned about these types of conversions. Although the performance impact of performing these types of conversions are minimal.
Changes to Users
Users do not explicitly have to convert the filter to the signal type before calling fftconvolve
Checklist
[ ] Functions added to unified API[ ] Functions documented