Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bounds check for FAST Nonmax #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bounds check for FAST Nonmax #3357

wants to merge 2 commits into from

Conversation

jlaxson
Copy link

@jlaxson jlaxson commented Jan 24, 2023 •
edited
Loading

This bounds check was broken in two ways:

  1. It happened after memory access already occurred, meaning it didn't really protect anything
  2. It swapped x/y checks in the dimension order.

The result was fast (and orb) features would not be returned for the entire image if the input image wasn't square.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@syurkevi syurkevi mentioned this pull request Jan 25, 2023
Open
@syurkevi syurkevi added this to the 3.9.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaxson @syurkevi