feat: add Hygraph support#142
Merged
Merged
Conversation
Owner
|
Thanks! Looking at the playground it doesn't seem to be cropping the images as expected. e.g. making this 100x600 gives a 100x100 image. Is there a param that can give the expected aspect ratio? The default should be equivalent to object-fit: cover, if it's supported. |
Contributor
Author
|
Good catch, fixed! |
Owner
|
Thanks. Can you enable edits from maintainers on the PR please |
Contributor
Author
|
Hmm, apparently I don't have that option because the fork is on an organization. https://github.com/orgs/community/discussions/5634 |
Owner
|
That's annoying. Can you update the branch then please. There should be a button just below this |
Contributor
Author
|
Done! |
ascorbic
requested changes
Nov 11, 2024
auto-merge was automatically disabled
November 11, 2024 14:11
Head branch was pushed to by a user without write access
ascorbic
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great lib.