feat: add Scene7 transformer#39
Merged
Merged
Conversation
Owner
|
That's awesome, thank you. There's a test failing right now. You can run it locally if you install Deno. There's instructions in the readme |
Contributor
Author
|
@ascorbic updated the failed test |
Owner
|
Great, thanks! Sorry one more thing: can you update it to default to fit=crop. This is the standard behaviour for other transformers, and we need them to match. I'll unpade the contributing guidelines to make that clearer. Thanks! |
Contributor
Author
|
@ascorbic Added in the default crop |
Owner
|
Perfect! Thanks for updating this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.