Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: don't include node type refs in declaration #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 2 commits into from
Sep 29, 2023
Merged

fix: don't include node type refs in declaration #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c31d9a1
fix: don't include node type refs in declaration
ascorbic Sep 29, 2023
3087372
chore: skip imageengine tests
ascorbic Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/src/examples.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"keycdn": ["KeyCDN", "https://ip.keycdn.com/example.jpg"],
"imageengine": [
"ImageEngine",
"https://blazing-fast-pics.cdn.imgeng.in/images/pic_1.jpg?imgeng=/w_400"
"https://blazing-fast-pics.cdn.imgeng.in/images/pic_3.jpg?imgeng=/w_400"
],
"contentstack": [
"Contentstack",
Expand Down
3 changes: 3 additions & 0 deletions scripts/build_npm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ await build({
},
},
rootTestDir: "./src",
compilerOptions: {
lib: ["ESNext", "WebWorker"],
},
package: {
// package.json properties
name: "unpic",
Expand Down
51 changes: 31 additions & 20 deletions src/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,33 +10,44 @@ import type { ImageCdn } from "./types.ts";
Deno.test("E2E tests", async (t) => {
for (const [cdn, example] of Object.entries(examples)) {
const [name, url] = example;
await t.step(`${name} resizes an image`, async () => {
const image = transformUrl({
url,
width: 100,
cdn: cdn as ImageCdn,
});
// ImageEngine is really flaky, so ignore it

assertExists(image, `Failed to resize ${name} with ${cdn}`);
const { width } = await getPixels(image);
const ignore = cdn === "imageengine";
await t.step({
name: `${name} resizes an image`,
fn: async () => {
const image = transformUrl({
url,
width: 100,
cdn: cdn as ImageCdn,
});

assertEquals(width, 100);
assertExists(image, `Failed to resize ${name} with ${cdn}`);
const { width } = await getPixels(image);

assertEquals(width, 100);
},
ignore,
});

await t.step(`${name} returns requested aspect ratio`, async () => {
const image = transformUrl({
url,
width: 100,
height: 50,
cdn: cdn as ImageCdn,
});
await t.step({
name: `${name} returns requested aspect ratio`,
fn: async () => {
const image = transformUrl({
url,
width: 100,
height: 50,
cdn: cdn as ImageCdn,
});

assertExists(image, `Failed to resize ${name} with ${cdn}`);
assertExists(image, `Failed to resize ${name} with ${cdn}`);

const { width, height } = await getPixels(image);
const { width, height } = await getPixels(image);

assertEquals(width, 100);
assertEquals(height, 50);
assertEquals(width, 100);
assertEquals(height, 50);
},
ignore,
});
}
});