fix: add ARIA labels to navigation for accessibility (#435)#437
Open
Pratham-r05 wants to merge 1 commit into
Open
fix: add ARIA labels to navigation for accessibility (#435)#437Pratham-r05 wants to merge 1 commit into
Pratham-r05 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #435 β The navigation hamburger menu button and nav element lacked ARIA attributes, making the site inaccessible for screen reader users.
Changes made (
src/components/header/Header.jsonly)aria-label="Toggle navigation menu"andaria-controls="nav-menu"to the hamburger checkbox input β screen readers now announce the button's purpose and its controlled regionaria-hidden="true"to the menu label β hides the decorative icon from assistive tech since the checkbox is already announcedid="nav-menu",role="navigation", andaria-label="Main navigation"to the<ul>β makes it a discoverable landmark and satisfies thearia-controlsreferenceWhat was NOT changed
Test plan
Header.test.js)renders without crashinghamburger checkbox has aria-label for togglehamburger checkbox has aria-controls pointing to nav menumenu label is hidden from screen readers via aria-hiddennav ul has correct id, role, and aria-labelaria-controls on checkbox matches id of nav ulCloses #435