Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add read methods to the snapshotter#21

Merged
artob merged 1 commit into
masterfrom
samuel/snapshot-read
Jul 22, 2025
Merged

Add read methods to the snapshotter#21
artob merged 1 commit into
masterfrom
samuel/snapshot-read

Conversation

@SamuelSarle
Copy link
Copy Markdown
Member

Tiny patch to forward the read and read_current methods from the storage.

@race-of-sloths

@SamuelSarle SamuelSarle requested a review from artob as a code owner July 22, 2025 12:20
@race-of-sloths
Copy link
Copy Markdown

race-of-sloths commented Jul 22, 2025

@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@artob 5

Your contribution is much appreciated with a final score of 5!
You have received 110 (50 base + 50 weekly bonus + 10% lifetime bonus) Sloth points for this contribution

@artob received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @SamuelSarle! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@artob artob requested a review from Copilot July 22, 2025 16:31
@artob artob self-assigned this Jul 22, 2025
@artob artob added the enhancement New feature or request label Jul 22, 2025
@artob artob moved this to In review in ASIMOV Platform 25 Jul 22, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds read functionality to the Snapshotter by exposing read and read_current methods that forward calls to the underlying storage layer. The changes also improve the API consistency by converting string parameters to use generic AsRef<str> bounds and enhance tracing instrumentation.

  • Adds two new public methods read and read_current to expose storage read functionality
  • Converts string parameters from &str to impl AsRef<str> for better API flexibility
  • Improves tracing instrumentation by adding URL field logging and removing unused output format option

Comment thread lib/asimov-snapshot/src/snapshot.rs
Comment thread lib/asimov-snapshot/src/snapshot.rs
Comment thread lib/asimov-snapshot/src/snapshot.rs
@artob
Copy link
Copy Markdown
Member

artob commented Jul 22, 2025

@race-of-sloths score 5

@artob artob merged commit 5694913 into master Jul 22, 2025
5 checks passed
@artob artob deleted the samuel/snapshot-read branch July 22, 2025 19:02
@github-project-automation github-project-automation Bot moved this from In review to Done in ASIMOV Platform 25 Jul 22, 2025
@artob artob changed the title Add read methods to snapshotter Add read methods to the snapshotter Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants