Update the read_manifest helper#25
Conversation
|
@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the read_manifest helper function to search for module manifests in multiple locations and formats to maintain backward compatibility while supporting a new JSON-based installation format.
Key changes:
- Replaces single-path manifest reading with multi-path search strategy
- Adds support for both JSON and YAML manifest formats
- Implements fallback logic for legacy manifest locations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/asimov-snapshot/src/snapshot.rs | Removes unused import of asimov_root function |
| lib/asimov-module/src/models/module_manifest.rs | Updates read_manifest to search multiple paths and support JSON/YAML formats |
|
🥁 Score it! @artob, please score the PR with |
Updates the
read_manifesthelper to match the newasimov_installerimplementation.The helper is/may be used by:
@race-of-sloths