Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make enabled module symlinks relative#26

Merged
artob merged 1 commit into
masterfrom
samuel/rel-symlink
Jul 31, 2025
Merged

Make enabled module symlinks relative#26
artob merged 1 commit into
masterfrom
samuel/rel-symlink

Conversation

@SamuelSarle
Copy link
Copy Markdown
Member

Tested to work with asimov-module-cli.

@race-of-sloths

@race-of-sloths
Copy link
Copy Markdown

race-of-sloths commented Jul 31, 2025

@SamuelSarle Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@artob 3

Your contribution is much appreciated with a final score of 3!
You have received 33 (30 base + 10% lifetime bonus) Sloth points for this contribution

@artob received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@artob artob requested a review from Copilot July 31, 2025 18:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the asimov installer to create relative symlinks in the enabled/ directory instead of absolute ones, improving portability and compatibility with the asimov-module-cli.

  • Updates manifest path resolution to handle both absolute and relative paths
  • Changes symlink creation to use relative paths pointing to the installed/ directory or legacy locations

Comment thread lib/asimov-installer/src/installer.rs
Comment thread lib/asimov-installer/src/installer.rs
Comment thread lib/asimov-installer/src/installer.rs
@artob artob added the enhancement New feature or request label Jul 31, 2025
@artob artob moved this to In review in ASIMOV Platform 25 Jul 31, 2025
@artob artob merged commit 8b87d29 into master Jul 31, 2025
5 checks passed
@artob artob deleted the samuel/rel-symlink branch July 31, 2025 20:36
@github-project-automation github-project-automation Bot moved this from In review to Done in ASIMOV Platform 25 Jul 31, 2025
@artob artob changed the title Make asimov_installer symlinks inside enabled/ relative Make enabled module symlinks relative Jul 31, 2025
@artob
Copy link
Copy Markdown
Member

artob commented Jul 31, 2025

@race-of-sloths score 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants