Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(py_*): Safer default application for exec_properties #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(py_*): Safer default application for exec_properties #633

wants to merge 2 commits into from

Conversation

arrdem
Copy link
Collaborator

@arrdem arrdem commented Aug 29, 2025

Tweak how we parse the exec_properties attribute so that the codepath is None-safe in case the user explicitly provided a None value somehow.

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Fixed #605.

Test plan

  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Aug 29, 2025 •
edited
Loading

Test

Buildkite build #380 is running...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@keith keith keith approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: py_test / py_binary incorrectly handle an exec_properties attribute that is explicitly set to None
2 participants
@arrdem @keith