This repository was archived by the owner on Jan 15, 2026. It is now read-only.
chore: add Bazel 8 testing #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94527dc to
06f48e5
Compare
fmeum
reviewed
Jan 15, 2025
Revert WORKSPACE-only changes
Member
Author
|
Still two test failures. One of them is something trying to compile abseil-cpp from source, and we assert here that no functional CC toolchain should be required. I think it may be rules_python's fault though, rather than rules_proto or protobuf. |
Contributor
|
Java protos still hit protocolbuffers/protobuf#19679, which hasn't been reviewed yet. But all other languages should work. |
Member
Author
|
Thanks, I'll try removing Java as well. |
jbedard
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest rules_proto has a fix to make this work, even though Bazel 8 moved the proto rule implementations to com_google_protobuf
Changes are visible to end-users: no
Test plan