Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Issue #689: Raise Exception for Duplicate Key #782

Closed
wants to merge 1 commit into from

Conversation

husainaloos
Copy link

Added feature:

  • When Azure Vault has a duplicate key for configuration, an
    invalidOperationException will be thrown that will indicate that there
    is a duplicate key, as well as the key itself.

Related Bugs/Issues:

Added feature:
- When Azure Vault has a duplicate key for configuration, an
invalidOperationException will be thrown that will indicate that there
is a duplicate key, as well as the key itself.

Related Bugs/Issues:
- Issue aspnet#689 on github.
@dnfclas
Copy link

dnfclas commented Feb 18, 2018

CLA assistant check
All CLA requirements met.

@natemcmaster natemcmaster changed the base branch from dev to master July 2, 2018 17:44
@ajcvickers
Copy link
Contributor

@husainaloos Thanks for submitting this. After looking at the behavior of all providers, the behavior is not consistent, but most providers throw an ArgumentException or a FormatException--https://github.com/aspnet/Extensions/issues/601. We would be open to a PR that changes these into a consistent single exception (InvalidOperationException is fine), but since this is a breaking change the value needs to be somewhat high, we would only do it as a consistent change across all providers. We would consider taking a PR for this.

We have recently consolidated the configuration code into the https://github.com/aspnet/Extensions repo. Unfortunately, it is not trivial to move PRs over to another repo, so will not be moving this PR over. However, it should not be too difficult to recreate in the new location if you wish to continue pursuing it.

@ajcvickers ajcvickers closed this Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants