This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Don't advance examined in Http1MessageBody.PumpAsync for canceled reads #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is happening now because of my change . I think it's a bug in pipelines. |
|
@davidfowl I think you may be right. I don't actually see how the initial examined value could be used in this case. We might want to change this pattern everywhere to only advance examine once we've actually examined the data just to be safe. What do you think about doing that @davidfowl? I could submit a new PR for this. |
|
Reopening for investigative purposes. |
pakrym
approved these changes
Aug 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2846