Merge from internal & fixup .npmrc #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nst potential Software Supply Chain attacks. This starts with ensuring your repository has a valid Azure Artifacts configuration so you can take advantage of [Central Feed Services](https://aka.ms/cfs). We are opening this PR with a fix on known issue(s) which we have detected in your repository. Please review and approve this PR at your earliest convenience. **This may impact the ability for pipelines and developers to install packages and build projects.** ## Address **breaking changes** before you merge: * Confirm the suggested Feed is configured per your organization's guidelines. If changes are necessary, work with your Project Administrators to set it up correctly. [Learn more...](https://docs.microsoft.com/en-us/azure/devops/artifacts/feeds/feed-permissions?view=azure-devops) * Add authentication to any failing pipeline definitions. [nuget](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/nuget-authenticate?view=azure-devops), [npm](https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/npm-authenticate?view=azure-devops). * Reach out to developers who may need to authenticate to the feed using the [internal_PublicPackages's Connect to feed](https://dev.azure.com/dnceng/internal/_artifacts/feed/internal_PublicPackages/connect) instructions in Azure Artifacts. ## Changes * `.npmrc` added as a sibling to this [package.json](/package.json) referencing [internal_PublicPackages](https://dev.azure.com/dnceng/internal/_artifacts/feed/internal_PublicPackages) feed ### Still stuck? Reach out to [email protected] with any questions. --- This change was automatically generated by [1ES Gardener](https://www.1eswiki.com/wiki/1ES_Gardener) which is an initiative by the 1ES team to help repos stay up-to-date with latest tools, features, and best practices. For feedback or questions, please contact the [Gardener team](mailto:[email protected]).
|
I believe merge-committing this will unblock the mirror (CC @dougbu) |
|
This apparently isn't a solution when building in public. /cc @mmitche |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We have a few warnings that could be addressed here or later: The first is a simple change to build.proj, as the warning suggests. The second is pretty simple too: I also recommend using The last one requires a slight change to the .nuspec to add the icon file (which isn't in the repo yet) and doing the right stuff to reference it. We have done that elsewhere, even w/o Arcade's help (though that does make it much easier.) |
dougbu
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged in the missing internal commit, and then updated the file as per https://github.com/dotnet/arcade-services/pull/1924/files