Add 'hasCauseSameAs' assertion for Throwables#1443
Closed
mike-jg wants to merge 1 commit intoassertj:masterfrom
Closed
Add 'hasCauseSameAs' assertion for Throwables#1443mike-jg wants to merge 1 commit intoassertj:masterfrom
mike-jg wants to merge 1 commit intoassertj:masterfrom
Conversation
e550e3e to
af01b6e
Compare
src/main/java/org/assertj/core/api/AbstractThrowableAssert.java
Outdated
Show resolved
Hide resolved
src/main/java/org/assertj/core/api/AbstractThrowableAssert.java
Outdated
Show resolved
Hide resolved
src/main/java/org/assertj/core/api/AbstractThrowableAssert.java
Outdated
Show resolved
Hide resolved
src/main/java/org/assertj/core/api/AbstractThrowableAssert.java
Outdated
Show resolved
Hide resolved
src/main/java/org/assertj/core/error/ShouldHaveCauseSameAs.java
Outdated
Show resolved
Hide resolved
| */ | ||
| package org.assertj.core.error; | ||
|
|
||
| public class ShouldHaveCauseSameAs extends BasicErrorMessageFactory { |
Member
There was a problem hiding this comment.
rename to ShouldHaveCauseReference
src/test/java/org/assertj/core/api/throwable/ThrowableAssert_hasCauseSameAs_Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/assertj/core/api/throwable/ThrowableAssert_hasCauseSameAs_Test.java
Outdated
Show resolved
Hide resolved
| private static final AssertionInfo INFO = someInfo(); | ||
|
|
||
| @Test | ||
| public void should_pass_if_actual_cause_and_expected_cause_are_the_same_instance() { |
src/test/java/org/assertj/core/internal/throwables/Throwables_assertHasCauseSameAs_Test.java
Outdated
Show resolved
Hide resolved
Member
|
@mike-jg thanks, I have commented the PR. |
af01b6e to
7048554
Compare
7048554 to
db8bff1
Compare
Contributor
Author
|
@joel-costigliola thanks for the review, I've updated the PR accordingly. |
Member
|
Integrated thanks @mike-jg for the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an assertion to check that a
Throwable's cause is identical to an expected cause.Check List: