Reviewing files that changed from the base of the PR and between 4370db5 and bae2c48.

• packages/react/src/runtimes/external-store/ThreadMessageLike.tsx (2 hunks)
• packages/react/src/types/AssistantTypes.ts (1 hunks)

packages/react/src/runtimes/external-store/ThreadMessageLike.tsx (3)

24-59: LGTM! The ThreadMessageLike type has been updated to support the 'data' role.

The type definition correctly includes the new role while maintaining the existing structure.

---

86-185: ⚠️ Potential issue

Add case for 'data' role in switch statement.

The switch statement doesn't handle the 'data' role, causing runtime errors when processing data messages. This is a critical issue that needs to be addressed.

Add a case for the 'data' role before the default case. Here's a suggested implementation:

 switch (role) {
   case "assistant":
     // ... existing assistant case
   case "user":
     // ... existing user case
   case "system":
     // ... existing system case
+  case "data":
+    return {
+      ...common,
+      role,
+      content: content.map((part): ThreadUserContentPart => {
+        const type = part.type;
+        switch (type) {
+          case "text":
+          case "file":
+            return part;
+          default: {
+            const unhandledType: "tool-call" | "reasoning" | "image" | "audio" | "ui" = type;
+            throw new Error(
+              `Unsupported data content part type: ${unhandledType}`,
+            );
+          }
+        }
+      }),
+      metadata: {
+        custom: metadata?.custom ?? {},
+      },
+    };
   default: {
     // ... existing default case
   }
 }

🧰 Tools

🪛 Biome (1.9.4)

[error] 107-107: Template literals are preferred over string concatenation.

Unsafe fix: Use a template literal.

(lint/style/useTemplate)

---

[error] 114-114: Template literals are preferred over string concatenation.

Unsafe fix: Use a template literal.

(lint/style/useTemplate)

---

[error] 167-167: Forbidden non-null assertion.

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator

(lint/style/noNonNullAssertion)

---

77-84: Define constraints for 'data' role.

The error handling section defines constraints for attachments, status, and metadata.steps. Consider if similar constraints should apply to the 'data' role.

Please verify:

1. Should attachments be allowed for data messages?
2. Should status be supported for data messages?
3. Should metadata.steps be supported for data messages?

packages/react/src/types/AssistantTypes.ts (2)

8-8: LGTM! MessageRole type updated to include 'data' role.

The type definition correctly includes the new role.

---

233-234: ⚠️ Potential issue

Add ThreadDataMessage type and update ThreadMessage union.

The 'data' role is added to MessageRole but there's no corresponding message type definition (like ThreadDataMessage) or handling in ThreadMessage union type.

Add the following type definitions:

+export type ThreadDataMessage = MessageCommonProps & {
+  readonly role: "data";
+  readonly content: readonly (TextContentPart | FileContentPart)[];
+  readonly metadata: {
+    readonly custom: Record<string, unknown>;
+  };
+};

-export type ThreadMessage = BaseThreadMessage &
-  (ThreadSystemMessage | ThreadUserMessage | ThreadAssistantMessage);
+export type ThreadMessage = BaseThreadMessage &
+  (ThreadSystemMessage | ThreadUserMessage | ThreadAssistantMessage | ThreadDataMessage);