[Proposal]: New tool calling DX #1770
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import { openai } from "@ai-sdk/openai"; | ||
| import { streamText } from "ai"; | ||
| // import { aiSDKAdapter } from "@assistant-ui/rea=-ct"; |
There was a problem hiding this comment.
There's a typo in the import comment for @assistant-ui/react where an equals sign is incorrectly included in the package name.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| // import { aiSDKAdapter } from "@assistant-ui/rea=-ct"; | |
| // import { aiSDKAdapter } from "@assistant-ui/react"; |
examples/with-ai-sdk/tools.ts
Outdated
| // }, | ||
| // }); | ||
|
|
||
| export const weatherTool = aiSDKAdapter(webSearchTool); |
There was a problem hiding this comment.
The aiSDKAdapter is applied to webSearchTool but should be applied to the corrected weatherTool implementation.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| export const weatherTool = aiSDKAdapter(webSearchTool); | |
| export const weatherToolAdapter = aiSDKAdapter(weatherTool); |
Pull request summary
|
Pull request summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal of a more typesafe way to define tools. I've made minimal adjustments to the existing set of types across the application but just re worked the tool schema definition.
The goal of this is to push the user to define their tools in a central set of places so that they can prevent duplicate tools, and take advantage of the type-safety that centralization provides. We split the tools into client and server tools, but the tools would eventually be registered in one "tool box" across the set of tools.
If this approach looks good I'll also add typesafe client side tool handling, it's a pita to do with existing tools and I'd love to fix it.