Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dsp.c: Improve debug logging in tone_detect().#1376

Merged
github-actions[bot] merged 1 commit into
asterisk:masterfrom
InterLinked1:master-issue-1375
Aug 18, 2025
Merged

dsp.c: Improve debug logging in tone_detect().#1376
github-actions[bot] merged 1 commit into
asterisk:masterfrom
InterLinked1:master-issue-1375

Conversation

@InterLinked1

Copy link
Copy Markdown
Contributor

The debug logging during DSP processing has always been kind of overwhelming and annoying to troubleshoot. Simplify and improve the logging in a few ways to aid DSP debugging:

  • If we had a DSP hit, don't also emit the previous debug message that was always logged. It is duplicated by the hit message, so this can reduce the number of debug messages during detection by 50%.
  • Include the hit count and required number of hits in the message so on partial detections can be more easily troubleshot.
  • Use debug level 9 for hits instead of 10, so we can focus on hits without all the noise from the per-frame debug message.
  • 1-index the hit count in the debug messages. On the first hit, it currently logs '0', just as when we are not detecting anything, which can be confusing.

Resolves: #1375

The debug logging during DSP processing has always been kind
of overwhelming and annoying to troubleshoot. Simplify and
improve the logging in a few ways to aid DSP debugging:

* If we had a DSP hit, don't also emit the previous debug message that
  was always logged. It is duplicated by the hit message, so this can
  reduce the number of debug messages during detection by 50%.
* Include the hit count and required number of hits in the message so
  on partial detections can be more easily troubleshot.
* Use debug level 9 for hits instead of 10, so we can focus on hits
  without all the noise from the per-frame debug message.
* 1-index the hit count in the debug messages. On the first hit, it
  currently logs '0', just as when we are not detecting anything,
  which can be confusing.

Resolves: asterisk#1375
@InterLinked1

Copy link
Copy Markdown
Contributor Author

cherry-pick-to: 23
cherry-pick-to: 22
cherry-pick-to: 21
cherry-pick-to: 20

@github-actions

Copy link
Copy Markdown

Workflow PRCheck completed successfully

@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Aug 18, 2025
@github-actions github-actions Bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Aug 18, 2025
@github-actions

Copy link
Copy Markdown

Workflow PRCPCheck completed successfully

@github-actions

Copy link
Copy Markdown

Successfully merged to branch master and cherry-picked to ["23","22","21","20"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[improvement]: dsp.c: Improve logging in tone_detect().

3 participants