users.conf: Deprecate users.conf configuration.#184
Merged
asterisk-org-access-app[bot] merged 1 commit intoJul 12, 2023
Conversation
Contributor
Author
|
No cherry picks required |
|
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking. If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required". |
9310803 to
c34c77c
Compare
Contributor
|
While not technically a module deprecation this will need to be discussed on the asterisk-dev list.
|
jcolp
requested changes
Jul 5, 2023
This deprecates the users.conf config file, which is no longer as widely supported but still integrated with a number of different modules. Because there is no real mechanism for marking a configuration file as "deprecated", and users.conf is not just used in a single place, this now emits a warning to the user when the PBX loads to notify about the deprecation. This configuration mechanism has been widely criticized and discouraged since its inception, and is no longer relevant to the configuration that most users are doing today. Removing it will allow for some simplification and cleanup in the codebase. Resolves: asterisk#183 UpgradeNote: The users.conf config is now deprecated and will be removed in a future version of Asterisk.
c34c77c to
a3ced31
Compare
jcolp
approved these changes
Jul 11, 2023
gtjoseph
approved these changes
Jul 12, 2023
|
Successfully merged to branch master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the users.conf config file, which
is no longer as widely supported but still integrated with a number of different modules.
Because there is no real mechanism for marking a
configuration file as "deprecated", and users.conf is not just used in a single place, this now emits a warning to the user when the PBX loads to notify about the deprecation.
This configuration mechanism has been widely criticized and discouraged since its inception, and is no longer relevant to the configuration that most users are doing today. Removing it will allow for some simplification and cleanup in the codebase.
Resolves: #183
UpgradeNote: The users.conf config is now deprecated and will be removed in a future version of Asterisk.