chan_dahdi: Clarify scope of callgroup/pickupgroup.#295
Merged
asterisk-org-access-app[bot] merged 1 commit intoOct 5, 2023
Merged
Conversation
Contributor
Author
|
cherry-pick-to: 18 |
Internally, chan_dahdi only applies callgroup and pickupgroup to FXO signalled channels, but this is not documented anywhere. This is now documented in the sample config, and a warning is emitted if a user tries configuring these settings for channel types that do not support these settings, since they will not have any effect. Resolves: asterisk#294
15fbfea to
6c31358
Compare
b15287c to
1862a36
Compare
jcolp
approved these changes
Sep 29, 2023
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, chan_dahdi only applies callgroup and
pickupgroup to FXO signalled channels, but this is not documented anywhere. This is now documented in the sample config, and a warning is emitted if a
user tries configuring these settings for channel
types that do not support these settings, since they will not have any effect.
Resolves: #294