Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sig_analog: Add Last Number Redial feature.#438

Merged
asterisk-org-access-app[bot] merged 1 commit into
asterisk:masterfrom
InterLinked1:master-issue-437
Jan 16, 2025
Merged

sig_analog: Add Last Number Redial feature.#438
asterisk-org-access-app[bot] merged 1 commit into
asterisk:masterfrom
InterLinked1:master-issue-437

Conversation

@InterLinked1

Copy link
Copy Markdown
Contributor

This adds the Last Number Redial feature to
simple switch.

UserNote: Users can now redial the last number
called if the lastnumredial setting is set to yes.

Resolves: #437

@InterLinked1

InterLinked1 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22

@jcolp

jcolp commented Nov 10, 2023

Copy link
Copy Markdown
Member

Why do this here in code instead of dialplan?

@InterLinked1

InterLinked1 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

Why do this here in code instead of dialplan?

If immediate=no, you can't easily capture the number dialed in the dialplan. It'll start executing it immediately so you'd have to have this logic at every extension, which is a complete mess.
I do this in my own code stack normally but on a "normal" Asterisk system this is really the only elegant way to do it.

@jcolp

jcolp commented Nov 10, 2023

Copy link
Copy Markdown
Member

So yes it is possible.

@InterLinked1

Copy link
Copy Markdown
Contributor Author

So yes it is possible.

No, not really, unless you have immediate=yes, which is the scenario to which I was referring. Otherwise this is too low level to be doable in the dialplan.

@jcolp

jcolp commented Nov 10, 2023

Copy link
Copy Markdown
Member

I disagree, I believe it is reasonably possible for the usage of most users and wouldn't surprise me if others have done so. That's my opinion though and I won't stop this, others are free to join in and review this if they wish. I may eventually get around to it.

This adds the Last Number Redial feature to
simple switch.

UserNote: Users can now redial the last number
called if the lastnumredial setting is set to yes.

Resolves: asterisk#437
@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Jan 16, 2025
@github-actions github-actions Bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-failed Cherry-Pick checks failed and removed cherry-pick-test Trigger dry run of cherry-picks cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Jan 16, 2025
@asterisk-org-access-app asterisk-org-access-app Bot merged commit 7854686 into asterisk:master Jan 16, 2025
@github-actions

Copy link
Copy Markdown

Successfully merged to branch master and cherry-picked to ["20","21","22"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[new-feature]: sig_analog: Add Last Number Redial

3 participants