pbx_variables.c: Prevent SEGV due to stack overflow.#481
Merged
asterisk-org-access-app[bot] merged 1 commit intoMar 22, 2024
Merged
Conversation
Contributor
Author
|
cherry-pick-to: 20 |
gtjoseph
requested changes
Dec 11, 2023
It is possible for dialplan to result in an infinite recursion of variable substitution, which eventually leads to stack overflow. If we detect this, abort substitution and log an error for the user to fix the broken dialplan. Resolves: asterisk#480 UpgradeNote: The maximum amount of dialplan recursion using variable substitution (such as by using EVAL_EXTEN) is capped at 15.
45e9a1e to
61d9ba7
Compare
Contributor
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
gtjoseph
approved these changes
Mar 21, 2024
gtjoseph
requested changes
Mar 21, 2024
gtjoseph
left a comment
Member
There was a problem hiding this comment.
Doesn't cherry pick to 18 so the PR will need to be split.
Contributor
Author
Done, linked PR: #663 |
gtjoseph
approved these changes
Mar 21, 2024
|
Successfully merged to branch master and cherry-picked to ["20","21"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible for dialplan to result in an infinite recursion of variable substitution, which eventually leads to stack overflow. If we detect this, abort
substitution and log an error for the user to fix
the broken dialplan.
Resolves: #480