configure: Rerun bootstrap on modern platform.#587
Conversation
|
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment with If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add The currently active branches are now 18, 20, 21 and master. |
|
Out of curiosity, what does using |
It's not a huge deal in this particular case, but we should be able to use restrict in general if needed, so I'm just doing this now rather than punting it. |
|
I guess what I really meant to ask was - what is the benefit of using |
Not that much, I suppose. You're right there's no performance benefit since it's not also reading. It's mostly semantic in that that variable isn't being used anywhere else. Do you think it should be removed? |
|
I don't have an opinion, I was just trying to understand the rationale for it being there in the first place. |
0dd4566 to
32aa74d
Compare
The last time configure was run, it was run on a system that did not enable -std=gnu11 by default, which meant that the restrict qualifier would not be recognized on certain platforms. This regenerates the configure files from running bootstrap.sh, so that these should be recognized on all supported platforms. Resolves: asterisk#586
32aa74d to
ca61b26
Compare
|
cherry-pick-to: none |
|
The title and description of this PR is now in conflict with what is actually being proposed. |
The commit message is correct. The PR doesn't update automatically, but I'll sync it now. |
|
I know that the commit message is correct. I mentioned the title and description of the PR. Thank you for making the change. |
|
Tested on CentOS 7 with gcc (GCC) 4.8.5 20150623 and ./configure now correctly sets |
gtjoseph
left a comment
There was a problem hiding this comment.
The cherry-picks all failed so I think you're gonna have to submit a PR for each branch :(
|
Successfully merged to branch master. |
The last time configure was run, it was run on a system that
did not enable -std=gnu11 by default, which meant that the
restrict qualifier would not be recognized on certain platforms.
This regenerates the configure files from running bootstrap.sh,
so that these should be recognized on all supported platforms.
Resolves: #586