app_dial: Fix progress timeout calculation with no answer timeout.#949
Merged
asterisk-org-access-app[bot] merged 1 commit intoOct 24, 2024
Merged
Conversation
If to_answer is -1, simply comparing to see if the progress timeout is smaller than the answer timeout to prefer it will fail. Add an additional check that chooses the progress timeout if there is no answer timeout (or as before, if the progress timeout is smaller). Resolves: asterisk#821
Contributor
Author
|
cherry-pick-to: 18 |
Member
|
rechecking to pick up app_dial tests. |
Member
Contributor
Author
Yup :) This change should be correct and when I modified the test to remove the issue with it, it does pass. |
Member
|
rechecking again to pick up latest test changes. |
gtjoseph
approved these changes
Oct 18, 2024
gtjoseph
left a comment
Member
There was a problem hiding this comment.
This change plus the corresponding testsuite PR now passes.
jcolp
approved these changes
Oct 23, 2024
|
Successfully merged to branch master and cherry-picked to ["18","20","21","22"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If to_answer is -1, simply comparing to see if the progress timeout is smaller than the answer timeout to prefer it will fail. Add an additional check that chooses the progress timeout if there is no answer timeout (or as before, if the progress timeout is smaller).
Resolves: #821