install_prereq: Fix SIPP compilation and python3 detection.#48
Merged
asterisk-org-access-app[bot] merged 1 commit intoApr 30, 2024
Merged
Conversation
Contributor
Author
|
cherry-pick-to: 18 |
ddc8496 to
1065069
Compare
Install SIPP 3.6.1 instead of 3.5.2, which no longer compiles properly. This now requires cmake, so also install cmake. Also use python3 if possible instead of python to avoid exiting non-zero if python3 exists but python does not (which it no longer does on many systems where only Python 3 is installed). Resolves: asterisk#47
1065069 to
a8b5ad1
Compare
gtjoseph
approved these changes
Apr 9, 2024
jcolp
approved these changes
Apr 9, 2024
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install SIPP 3.6.1 instead of 3.5.2, which no longer compiles properly.
Also use python3 if possible instead of python to
avoid exiting non-zero if python3 exists but python does not (which it no longer does on many systems
where only Python 3 is installed).
Resolves: #47