app_record: Add tests for Record and RECORDING_INFO.#86
Merged
github-actions[bot] merged 1 commit intoJul 15, 2025
Conversation
|
Workflow PRCheck completed successfully |
Contributor
Author
|
This test should not be merged as is. This test passes, but for some reason it hangs after passing until killed after 50 seconds, and I haven't been able to figure out why exactly. |
Member
|
Fixing the channel lock may resolve that. |
Member
|
What's the new state of this? |
Contributor
Author
Your earlier presumption was right - this test passes fine now. |
jcolp
approved these changes
Jul 8, 2025
Member
|
@InterLinked1 Is this test cherry-pickable? |
Contributor
Author
|
cherry-pick-to: 22 |
Contributor
Author
Sorry about that... I keep forgetting the test suite has branches too - comment added |
|
Workflow PRCPCheck completed successfully |
|
Successfully merged to branch master and cherry-picked to ["22","21","20"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.