Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FastScannerRandomTest.java: Use our toHexString() instead of Logback's. #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

FastScannerRandomTest.java: Use our toHexString() instead of Logback's. #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c3381
FastScannerRandomTest.java: Use our `toHexString()` instead of Logbac…
seanbright Aug 17, 2024
8e85366
pom.xml: Drop Logback dependency entirely.
seanbright Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ updates:
interval: "daily"
labels:
- "kind/dependencies"
ignore:
# As long as we support Java 8
- dependency-name: "logback-classic"
update-types: [ "version-update:semver-major", "version-update:semver-minor" ]
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,6 @@
<version>4.10.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.3.12</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/org/asteriskjava/util/internal/streamreader/FastScannerRandomTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.asteriskjava.util.internal.streamreader;

import ch.qos.logback.core.encoder.ByteArrayUtil;
import org.asteriskjava.manager.internal.ManagerUtil;
import org.asteriskjava.util.internal.SocketConnectionFacadeImpl;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -72,8 +72,8 @@ void compare(String testData, Pattern pattern) throws IOException {

if (!fastResult.equals(scannerResult)) {

System.out.println("Expected " + ByteArrayUtil.toHexString(scannerResult.getBytes()));
System.out.println("Got " + ByteArrayUtil.toHexString(fastResult.getBytes()));
System.out.println("Expected " + ManagerUtil.toHexString(scannerResult.getBytes()));
System.out.println("Got " + ManagerUtil.toHexString(fastResult.getBytes()));
System.out.println("Error " + ctr);
System.out.println("");

Expand Down
Loading