Support hierarchical settings for nested directories - #1190
Merged
Conversation
charliermarsh
marked this pull request as draft
December 11, 2022 03:41
charliermarsh
force-pushed
the
charlie/configuration-i
branch
5 times, most recently
from
December 11, 2022 03:54
a2784c5 to
7d7e227
Compare
charliermarsh
marked this pull request as ready for review
December 11, 2022 03:54
Member
Author
|
There's a small performance hit here from doing two filesystem traversals. It might be possible to avoid it, since we could in theory track the "current" |
charliermarsh
force-pushed
the
charlie/configuration-i
branch
from
December 11, 2022 03:57
7d7e227 to
d8afad9
Compare
charliermarsh
force-pushed
the
charlie/configuration-i
branch
3 times, most recently
from
December 11, 2022 22:25
0de5bcb to
cd88ec0
Compare
charliermarsh
force-pushed
the
charlie/configuration-i
branch
from
December 12, 2022 05:10
cd88ec0 to
4bfc7af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to introduce hierarchical settings detection for Ruff, similar to the ESLint model, such that when we go to lint a given file, we always use the
pyproject.tomlfile "closest" to that file in the filesystem hierarchy.This has a number of nice side effects -- namely, linting a file becomes independent of the path from which the linter was invoked, and independent of the list of files passed to the
ruffinvocation (neither of which are true today).(There's one caveat here which is that the
fixandformatpyproject.tomloptions, which are semantically part of the invocation, aren't going to be inherited -- so we'll use the current working directory to find thepyproject.tomlto power those two, specific options.)Resolves #1069.