Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pylint] Do not wrap function calls in parentheses in the fix for unnecessary-dunder-call (PLC2801) #14601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylwil3 merged 3 commits into from
Nov 26, 2024
Merged

[pylint] Do not wrap function calls in parentheses in the fix for unnecessary-dunder-call (PLC2801) #14601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b93b8eb
update fixture
dylwil3 Nov 26, 2024
c938e1a
function calls never need to be wrapped in parens
dylwil3 Nov 26, 2024
f05975a
update snapshot
dylwil3 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/pylint/unnecessary_dunder_call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,6 @@ def use_descriptor(self, item):
blah = dict[{"a": 1}.__delitem__("a")] # OK

"abc".__contains__("a")

# https://github.com/astral-sh/ruff/issues/14597
assert "abc".__str__() == "abc"
24 changes: 15 additions & 9 deletions crates/ruff_linter/src/rules/pylint/rules/unnecessary_dunder_call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,21 @@ pub(crate) fn unnecessary_dunder_call(checker: &mut Checker, call: &ast::ExprCal
);

if let Some(mut fixed) = fixed {
// by the looks of it, we don't need to wrap the expression in parens if
// it's the only argument to a call expression.
// being in any other kind of expression though, we *will* add parens.
// e.g. `print(a.__add__(3))` -> `print(a + 3)` instead of `print((a + 3))`
// a multiplication expression example: `x = 2 * a.__add__(3)` -> `x = 2 * (a + 3)`
let wrap_in_paren = checker
.semantic()
.current_expression_parent()
.is_some_and(|parent| !can_be_represented_without_parentheses(parent));
let dunder = DunderReplacement::from_method(attr);

// We never need to wrap builtin functions in extra parens
// since function calls have high precedence
let wrap_in_paren = (!matches!(dunder, Some(DunderReplacement::Builtin(_,_))))
// By the looks of it, we don't need to wrap the expression in
// parens if it's the only argument to a call expression.
// Being in any other kind of expression though, we *will*
// add parens. e.g. `print(a.__add__(3))` -> `print(a + 3)`
// instead of `print((a + 3))`
// and `x = 2 * a.__add__(3)` -> `x = 2 * (a + 3)`
&& checker
.semantic()
.current_expression_parent()
.is_some_and(|parent| !can_be_represented_without_parentheses(parent));

if wrap_in_paren {
fixed = format!("({fixed})");
Expand Down
20 changes: 20 additions & 0 deletions ...lint/snapshots/ruff_linter__rules__pylint__tests__PLC2801_unnecessary_dunder_call.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,8 @@ unnecessary_dunder_call.py:104:1: PLC2801 [*] Unnecessary dunder call to `__cont
103 |
104 | "abc".__contains__("a")
| ^^^^^^^^^^^^^^^^^^^^^^^ PLC2801
105 |
106 | # https://github.com/astral-sh/ruff/issues/14597
|
= help: Use `in` operator

Expand All @@ -1097,3 +1099,21 @@ unnecessary_dunder_call.py:104:1: PLC2801 [*] Unnecessary dunder call to `__cont
103 103 |
104 |-"abc".__contains__("a")
104 |+"a" in "abc"
105 105 |
106 106 | # https://github.com/astral-sh/ruff/issues/14597
107 107 | assert "abc".__str__() == "abc"

unnecessary_dunder_call.py:107:8: PLC2801 [*] Unnecessary dunder call to `__str__`. Use `str()` builtin.
|
106 | # https://github.com/astral-sh/ruff/issues/14597
107 | assert "abc".__str__() == "abc"
| ^^^^^^^^^^^^^^^ PLC2801
|
= help: Use `str()` builtin

ℹ Unsafe fix
104 104 | "abc".__contains__("a")
105 105 |
106 106 | # https://github.com/astral-sh/ruff/issues/14597
107 |-assert "abc".__str__() == "abc"
107 |+assert str("abc") == "abc"