Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ruff] Implemented in-compare-with-single-item-container (RUF051)#14610

Closed
Lokejoke wants to merge 2 commits into
astral-sh:mainfrom
Lokejoke:ruf/in-compare-with-single-item-container
Closed

[ruff] Implemented in-compare-with-single-item-container (RUF051)#14610
Lokejoke wants to merge 2 commits into
astral-sh:mainfrom
Lokejoke:ruf/in-compare-with-single-item-container

Conversation

@Lokejoke

@Lokejoke Lokejoke commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Summary

This PR implements wps rule in-compare-with-single-item-container. Discussed here.
Use of in or not in operator on single item container is unnecessary.

Test Plan

cargo test

@github-actions

github-actions Bot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+87 -0 violations, +0 -0 fixes in 12 projects; 43 projects unchanged)

RasaHQ/rasa (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/core/test_examples.py:20:37: RUF051 Avoid comparing to a single item container with membership operator

apache/airflow (+17 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ airflow/utils/db.py:1389:24: RUF051 Avoid comparing to a single item container with membership operator
+ airflow/www/extensions/init_views.py:142:79: RUF051 Avoid comparing to a single item container with membership operator
+ dev/breeze/src/airflow_breeze/utils/run_tests.py:346:26: RUF051 Avoid comparing to a single item container with membership operator
+ hatch_build.py:584:67: RUF051 Avoid comparing to a single item container with membership operator
+ providers/src/airflow/providers/google/cloud/triggers/cloud_build.py:90:55: RUF051 Avoid comparing to a single item container with membership operator
+ providers/src/airflow/providers/snowflake/triggers/snowflake_trigger.py:81:58: RUF051 Avoid comparing to a single item container with membership operator
+ providers/tests/common/sql/sensors/test_sql.py:147:108: RUF051 Avoid comparing to a single item container with membership operator
+ providers/tests/common/sql/sensors/test_sql.py:171:36: RUF051 Avoid comparing to a single item container with membership operator
+ providers/tests/common/sql/sensors/test_sql.py:193:36: RUF051 Avoid comparing to a single item container with membership operator
+ providers/tests/common/sql/sensors/test_sql.py:194:36: RUF051 Avoid comparing to a single item container with membership operator
... 7 additional changes omitted for project

apache/superset (+2 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/connectors/sqla/models.py:859:71: RUF051 Avoid comparing to a single item container with membership operator
+ superset/models/helpers.py:1888:32: RUF051 Avoid comparing to a single item container with membership operator

lnbits/lnbits (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ lnbits/db.py:126:25: RUF051 Avoid comparing to a single item container with membership operator

milvus-io/pymilvus (+14 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pymilvus/bulk_writer/buffer.py:343:40: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/abstract.py:60:38: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/abstract.py:66:38: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/abstract.py:685:43: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/abstract.py:68:38: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/abstract.py:75:38: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/prepare.py:831:32: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/prepare.py:848:32: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/prepare.py:852:32: RUF051 Avoid comparing to a single item container with membership operator
+ pymilvus/client/prepare.py:861:25: RUF051 Avoid comparing to a single item container with membership operator
... 4 additional changes omitted for project

pandas-dev/pandas (+29 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ asv_bench/benchmarks/plotting.py:37:22: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/core/dtypes/common.py:1712:23: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/core/groupby/ops.py:456:30: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/io/pytables.py:716:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/extension/test_arrow.py:459:62: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/frame/test_arithmetic.py:109:19: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/frame/test_arithmetic.py:583:18: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:171:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:173:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:189:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:191:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:193:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:195:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:249:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:251:26: RUF051 Avoid comparing to a single item container with membership operator
+ pandas/tests/groupby/test_api.py:255:26: RUF051 Avoid comparing to a single item container with membership operator
... 13 additional changes omitted for project

pypa/cibuildwheel (+8 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ test/test_manylinuxXXXX_only.py:110:27: RUF051 Avoid comparing to a single item container with membership operator
+ test/test_manylinuxXXXX_only.py:114:27: RUF051 Avoid comparing to a single item container with membership operator
+ test/test_manylinuxXXXX_only.py:126:27: RUF051 Avoid comparing to a single item container with membership operator
+ test/test_manylinuxXXXX_only.py:84:27: RUF051 Avoid comparing to a single item container with membership operator
+ test/test_manylinuxXXXX_only.py:87:27: RUF051 Avoid comparing to a single item container with membership operator
+ test/test_manylinuxXXXX_only.py:90:27: RUF051 Avoid comparing to a single item container with membership operator
+ unit_test/oci_container_test.py:550:33: RUF051 Avoid comparing to a single item container with membership operator
+ unit_test/oci_container_test.py:580:33: RUF051 Avoid comparing to a single item container with membership operator

python-poetry/poetry (+2 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/poetry/console/commands/self/remove.py:10:62: RUF051 Avoid comparing to a single item container with membership operator
+ src/poetry/utils/shell.py:120:26: RUF051 Avoid comparing to a single item container with membership operator

scikit-build/scikit-build (+2 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ skbuild/platform_specifics/linux.py:40:35: RUF051 Avoid comparing to a single item container with membership operator
+ tests/test_issue668_symbol_visibility.py:22:38: RUF051 Avoid comparing to a single item container with membership operator

scikit-build/scikit-build-core (+1 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/test_settings_overrides.py:441:18: RUF051 Avoid comparing to a single item container with membership operator

zulip/zulip (+6 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ zerver/actions/presence.py:85:23: RUF051 Avoid comparing to a single item container with membership operator
+ zerver/lib/emoji.py:107:30: RUF051 Avoid comparing to a single item container with membership operator
+ zerver/lib/narrow_predicate.py:60:50: RUF051 Avoid comparing to a single item container with membership operator
+ zerver/tests/test_realm.py:2118:24: RUF051 Avoid comparing to a single item container with membership operator
+ zerver/tests/test_settings.py:234:26: RUF051 Avoid comparing to a single item container with membership operator
+ zerver/tests/test_subs.py:2692:38: RUF051 Avoid comparing to a single item container with membership operator

pytest-dev/pytest (+4 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ src/_pytest/pathlib.py:102:24: RUF051 Avoid comparing to a single item container with membership operator
+ testing/_py/test_local.py:679:21: RUF051 Avoid comparing to a single item container with membership operator
+ testing/_py/test_local.py:680:21: RUF051 Avoid comparing to a single item container with membership operator
+ testing/test_assertrewrite.py:637:25: RUF051 Avoid comparing to a single item container with membership operator

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF051 87 87 0 0 0

@Lokejoke Lokejoke marked this pull request as ready for review November 26, 2024 13:43
@dylwil3 dylwil3 added the rule Implementing or modifying a lint rule label Nov 26, 2024
@charliermarsh

charliermarsh commented Nov 26, 2024

Copy link
Copy Markdown
Member

This might be a duplicate of https://docs.astral.sh/ruff/rules/single-item-membership-test/?

@Lokejoke

Lokejoke commented Nov 26, 2024

Copy link
Copy Markdown
Contributor Author

Missed it again, sorry.

@Lokejoke Lokejoke closed this Nov 26, 2024
@Lokejoke Lokejoke mentioned this pull request Dec 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lokejoke @charliermarsh @dylwil3