[ty] Fix the Pyodide assets deployment in the ty playground.#24994
Merged
Conversation
carljm
added a commit
that referenced
this pull request
May 6, 2026
* main: (63 commits) Update uraimo/run-on-arch-action action to v3.1.0 (#25011) Update dependency astral-sh/uv to v0.11.10 (#25002) Update prek dependencies (#25003) Update taiki-e/install-action action to v2.75.25 (#25007) Update Rust crate mimalloc to v0.1.50 (#25006) Update Rust crate libc to v0.2.186 (#25005) Update maturin to v1.13.1 (#25009) Update CodSpeedHQ/action action to v4.15.0 (#25008) Update Rust crate jiff to v0.2.24 (#25004) Increase max value of `line-length` setting (#24962) [ty] Fix the Pyodide assets deployment in the ty playground. (#24994) [ty] Selectively promote a union of homogeneous fixed-length tuples to a single variadic tuple. (#24705) [ty] Cache results in desperate module resolution (#24977) [ty] implement proper handling of recursive types in `CycleDetector` (#24773) [ty] Skip parameter accumulation for object variadics (#24976) Add missing rust related files when detecting changes in CI (#24971) [ty] Expand support for narrowing within walruses (#24968) [ty] Fix missing visitor guard in `Callable` branch (#24964) [ty] Allow reference finding in stringified annotations (#24956) [ty] Unpack Union of TypedDict in various sites (#24958) ...
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…sh#24994) <!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? - Does this PR follow our AI policy (https://github.com/astral-sh/.github/blob/main/AI_POLICY.md)? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> - Adds some graceful degradation to Pyodide loading failures in the ty playground (with the result that the entire playground UI doesn't disappear if we only fail to execute a code run). - Corrects the placement of assets in our playground deployment, and adds some validation to the deployment workflow as a simple regression test Closes astral-sh/ty#3409. ## Test Plan I've verified the new asset layout in a local build of the playground. I think that's sufficient, but I will monitor the production playground deployment and revert this change if necessary. <!-- How was it tested? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#3409.
Test Plan
I've verified the new asset layout in a local build of the playground. I think that's sufficient, but I will monitor the production playground deployment and revert this change if necessary.