Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ty] Retain recursively-defined state in binary expressions #25277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 1 commit into from
May 21, 2026
+29 −2
Merged

[ty] Retain recursively-defined state in binary expressions #25277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@ reveal_type(C().FINAL_D) # revealed: Literal[1]
reveal_type(C().FINAL_E) # revealed: int
```

### Recursive bare `Final` instance attribute

```py
from __future__ import annotations

from typing import Final

class ScopeChain:
def __init__(self, parent: ScopeChain | None = None) -> None:
self.depth: Final = 1 if parent is None else parent.depth + 1
```

## Not modifiable

### Names
Expand Down
19 changes: 17 additions & 2 deletions crates/ty_python_semantic/src/types/infer/builder/binary_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use crate::types::cyclic::CycleDetector;
use crate::types::diagnostic::{
DIVISION_BY_ZERO, report_unsupported_augmented_assignment, report_unsupported_binary_operation,
};
use crate::types::set_theoretic::RecursivelyDefined;
use crate::types::typevar::TypeVarConstraints;
use crate::types::{
DynamicType, InternedConstraintSet, KnownClass, KnownInstanceType, LiteralValueTypeKind,
Expand Down Expand Up @@ -550,7 +551,14 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
(Type::Never, _, _) | (_, Type::Never, _) => Some(Type::Never),

(Type::LiteralValue(left), Type::LiteralValue(right), _) => {
match (left.kind(), right.kind(), op) {
let recursively_defined = if left.recursively_defined().is_yes()
|| right.recursively_defined().is_yes()
{
RecursivelyDefined::Yes
} else {
RecursivelyDefined::No
};
let result = match (left.kind(), right.kind(), op) {
(
LiteralValueTypeKind::Int(n),
LiteralValueTypeKind::Int(m),
Expand Down Expand Up @@ -827,7 +835,14 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
}

_ => Type::try_call_bin_op_return_type(db, left_ty, op, right_ty),
}
};

result.map(|result| match result {
Type::LiteralValue(literal) => {
Type::LiteralValue(literal.with_recursively_defined(recursively_defined))
}
_ => result,
})
}

(
Expand Down
Loading