fix(cli): add missing shutdown_plugins() in astridd shutdown path - #24
Merged
Merged
Conversation
The astridd binary (daemon_main.rs) called shutdown_servers() but not shutdown_plugins() before shutting down. This could leave MCP plugin child processes running as orphans. Matches the shutdown sequence already used in commands/daemon.rs.
Member
Author
|
Can confirm that child processes are shut down. |
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astriddbinary (daemon_main.rs) calledshutdown_servers()but notshutdown_plugins()before shutting downshutdown_plugins().awaitcall, matching the shutdown sequence already used incommands/daemon.rsTest plan
cargo check -p astrid-cli— clean