Fix api test issues #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not actually testing passing in a file name...it was passing in an HDU.
Which, admittedly, should have been the approach from the beginning.
It is not even clear colormaps are part of the API...
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues in the API compatibility tests by fixing marker table return properties and error conditions while also marking the colormap test as xfail. Key changes include:
- Renaming and updating marker table check functions and replacing direct attribute accesses with helper methods.
- Modifying the FITS loading test to write and read from a temporary file.
- Enhancing error matching in tests for offset operations, stretch, and cuts.
Comments suppressed due to low confidence (1)
src/astro_image_display_api/widget_api_test.py:52
- [nitpick] Consider renaming '_check_empty_marker_table_return_properties' to a more concise name like '_assert_empty_marker_table' for clarity and brevity.
def _check_empty_marker_table_return_properties(self, table):
There was a problem hiding this comment.
Pull Request Overview
This PR addresses API test issues by refactoring marker-related testing functions, refining exception match patterns, and marking the colormap test as xfail for downstream compatibility.
- Renamed the marker table check method for clarity
- Updated exception match patterns in several tests
- Reworked file I/O in the FITS loading test and marked colormap tests as xfail
Comments suppressed due to low confidence (1)
src/astro_image_display_api/widget_api_test.py:110
- Verify that the error message pattern 'are not convertible' matches the actual message from the underlying unit conversion logic, considering possible library updates.
with pytest.raises(u.UnitConversionError, match='are not convertible'):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that there were a number of issues in the file that downstream packages would use to test API compatibility. This PR fixes them and marks one as
xfailthat tests colormaps.