Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adjust IERS update workflow to open PRs against v5.0.x and v5.3.x - #15013

Merged
pllim merged 1 commit into
astropy:mainfrom
astrofrog:iers-auto-updates-release-branches
Jul 8, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
astrofrog:iers-auto-updates-release-branches

Conversation

@astrofrog

Copy link
Copy Markdown
Member

This will be needed once #14819 is merged. I have tested this on my local fork and it seems to work (including on the LTS branch).

@astrofrog astrofrog added the skip-changelog-checks Tells bot to skip changlog checks label Jul 3, 2023
@astrofrog astrofrog added this to the v6.0 milestone Jul 3, 2023
@github-actions

github-actions Bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim previously requested changes Jul 3, 2023

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno... I thought you would have this workflow in the workflow file directly in that branch. That way, we don't have to remove this on main again when we drop LTS in a few months.

@astrofrog

Copy link
Copy Markdown
Member Author

Cron jobs can only run on main - but we do check out the correct branches

@pllim
pllim dismissed their stale review July 3, 2023 14:19

Oh I never realized it does not run in backport branches!

@pllim

pllim commented Jul 3, 2023

Copy link
Copy Markdown
Member

Okay, in that case, maybe a follow-up issue milestoned to 6.0 so we remember to disable it when LTS is done. Thanks!

@astrofrog

Copy link
Copy Markdown
Member Author

Issue opened at #15030

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim

pllim commented Jul 6, 2023

Copy link
Copy Markdown
Member

I won't merge yet since you need that other thing to get in first.

@pllim

pllim commented Jul 7, 2023

Copy link
Copy Markdown
Member

There is a conflict. Please rebase, then we can merge. Thanks!

@astrofrog
astrofrog force-pushed the iers-auto-updates-release-branches branch from 6421086 to 0d5270e Compare July 7, 2023 22:46
@astrofrog

Copy link
Copy Markdown
Member Author

@pllim - rebased!

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
pllim enabled auto-merge July 7, 2023 22:48
@pllim
pllim merged commit 1ef68aa into astropy:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-checks Tells bot to skip changlog checks testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants