Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Fix IERS_Auto logic now that IERS-A is bundled" - #16695

Closed
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:revert-16187-iers_a
Closed

neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:revert-16187-iers_a

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

temporarily revert #16187
see #16693 for details

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros marked this pull request as ready for review July 10, 2024 09:39
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

I'm seeing some surprising (and seemingly related) errors within allowed_failures. I can't take another look before tommorow so please make sure you understand what's happening there if you're going to merge this.
Let me also ping @ayshih for visibility.

@ayshih

ayshih commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

I don't understand the failures here, so I'm hoping that a server just happened to be down at the time of the CI runs. This reversion PR should be mooted by the fixes in #16697

@pllim

pllim commented Jul 10, 2024

Copy link
Copy Markdown
Member

Thanks! I would prefer #16697 but let's see how the CI fares over there first.

@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release skip-changelog-checks Tells bot to skip changlog checks labels Jul 10, 2024
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Yes this one iss definitely not more than a plan B, thanks @ayshih for coming up with an actual fix !

@mhvk mhvk closed this in #16697 Jul 11, 2024
@neutrinoceros
neutrinoceros deleted the revert-16187-iers_a branch July 12, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release coordinates Docs skip-changelog-checks Tells bot to skip changlog checks utils.iers utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants