Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport PR #17359 on branch v7.0.x ([7.0.0rc1] Mark some "future" test in coordinates as remote_data) - #17373

Merged
pllim merged 1 commit into
astropy:v7.0.xfrom
meeseeksmachine:auto-backport-of-pr-17359-on-v7.0.x
Nov 11, 2024
Merged

pllim merged 1 commit into
astropy:v7.0.xfrom
meeseeksmachine:auto-backport-of-pr-17359-on-v7.0.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #17359: [7.0.0rc1] Mark some "future" test in coordinates as remote_data

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Nov 11, 2024

Copy link
Copy Markdown
Member

If there won't be RC2, please change milestone, @saimn . Thanks!

@pllim
pllim enabled auto-merge November 11, 2024 14:30
@pllim
pllim disabled auto-merge November 11, 2024 14:45
@pllim
pllim merged commit b9dcc33 into astropy:v7.0.x Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants