Add WCS.preserve_units property #18465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is preserving the original units from the header or set programmatically, or whether some units may have been converted to SI or degrees
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Do you want to at least amend the original change log to mention this new property? |
mcara
reviewed
Jul 28, 2025
Comment on lines
+3596
to
+3597
| If `True`, units are always kept as specified, whereas is `False`, some | ||
| units may in some cases be converted to SI or degrees. |
There was a problem hiding this comment.
Don't commit suggested change - it is for illustration only but I would prefer a little bit mode details (for the users) on what this does.
Suggested change
| If `True`, units are always kept as specified, whereas is `False`, some | |
| units may in some cases be converted to SI or degrees. | |
| If `True`, units are always kept as specified in/by header's CUNIT keywords, whereas is `False`, some | |
| units may in some cases (excluding -TAB axes type) be converted to SI or degrees. |
"some units in some cases" sounds vague.
| @@ -424,10 +424,12 @@ def __init__( | |||
| fix=True, | |||
| translate_units="", | |||
| _do_set=True, | |||
| preserve_units=False, | |||
| preserve_units=None, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indicates whether the WCS class is preserving the original units from the header or set programmatically, or whether some units may have been converted to SI or degrees. Not adding a changelog entry since this just affects a feature added in dev.