Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Jul 29, 2025

Description

Follow up to #18457

close #18187

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros added the backport-v7.1.x on-merge: backport to v7.1.x label Jul 29, 2025
@neutrinoceros
Copy link
Contributor Author

Whoops, I forgot we didn't have ABI stability on these wheels yet. I'll move this to draft for now, it should probably be done at the same time that cibuildwheel is upgraded.

@neutrinoceros neutrinoceros marked this pull request as draft July 29, 2025 11:07
@neutrinoceros neutrinoceros force-pushed the mnt/missing-cp314-pypi-classifier branch from ad0bd46 to 29e0fe1 Compare July 29, 2025 15:50
@neutrinoceros neutrinoceros changed the title MNT: add missing Python 3.14 PyPI classifier WHL: build/test wheels against ABI stable Python 3.14.0rc1 Jul 29, 2025
@neutrinoceros neutrinoceros linked an issue Jul 29, 2025 that may be closed by this pull request
6 tasks
@neutrinoceros
Copy link
Contributor Author

This now closes #18187

@neutrinoceros neutrinoceros added the Build all wheels Run all the wheel builds rather than just a selection label Jul 29, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review July 29, 2025 15:51
@neutrinoceros neutrinoceros force-pushed the mnt/missing-cp314-pypi-classifier branch from 29e0fe1 to 3929008 Compare July 29, 2025 16:02
@neutrinoceros neutrinoceros force-pushed the mnt/missing-cp314-pypi-classifier branch from 3929008 to d7d4230 Compare July 30, 2025 09:25
@pllim
Copy link
Member

pllim commented Jul 31, 2025

So just to be sure, this is ready for final review?

@neutrinoceros
Copy link
Contributor Author

Yes

@pllim pllim requested a review from astrofrog July 31, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.1.x on-merge: backport to v7.1.x Build all wheels Run all the wheel builds rather than just a selection installation no-changelog-entry-needed Python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHL: enabling Python 3.14 wheels
2 participants