Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make parsing deprecated units obey parse_strict #18536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make parsing deprecated units obey parse_strict #18536

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51c826d
Show that deprecated units ignore `parse_strict`
eerovaher Aug 20, 2025
d829da9
Make deprecated units obey `parse_strict`
eerovaher Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Show that deprecated units ignore parse_strict 
The updated tests demonstrate that parsing deprecated units with
`u.Unit(..., parse_strict=...)` ignores the `parse_strict` argument.
  • Loading branch information
@eerovaher
eerovaher committed Aug 20, 2025
commit 51c826dd28924bcd16085594b59e533c3fcc78ac
29 changes: 23 additions & 6 deletions astropy/units/tests/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,12 @@ def check_roundtrip(self, unit, output_format=None):
s = unit.to_string(output_format)

if s in self.format_._deprecated_units:
with pytest.warns(UnitsWarning, match="deprecated") as w:
a = Unit(s, format=self.format_)
with pytest.raises(ValueError, match="deprecated"):
Unit(s, format=self.format_)
with pytest.warns(UnitParserWarning, match="deprecated") as w:
a = Unit(s, format=self.format_, parse_strict="warn")
assert len(w) == 1
assert Unit(s, format=self.format_, parse_strict="silent") == a
else:
a = Unit(s, format=self.format_) # No warning

Expand Down Expand Up @@ -400,7 +403,16 @@ class TestRoundtripVOUnit(RoundtripBase):

@pytest.mark.parametrize(
"unit",
[u for u in u_format.VOUnit._units.values() if not isinstance(u, PrefixUnit)],
[
pytest.param(
u,
marks=[pytest.mark.xfail(reason="regression test that reveals a bug")]
if str(u) in u_format.VOUnit._deprecated_units
else [],
)
for u in u_format.VOUnit._units.values()
if not isinstance(u, PrefixUnit)
],
ids=str,
)
def test_roundtrip(self, unit):
Expand Down Expand Up @@ -452,7 +464,12 @@ class TestRoundtripOGIP(RoundtripBase):
@pytest.mark.parametrize(
"unit",
[
unit
pytest.param(
unit,
marks=[pytest.mark.xfail(reason="regression test that reveals a bug")]
if str(unit) in u_format.OGIP._deprecated_units
else [],
)
for unit in u_format.OGIP._units.values()
if (isinstance(unit, UnitBase) and not isinstance(unit, PrefixUnit))
],
Expand Down Expand Up @@ -717,6 +734,7 @@ def test_scaled_dimensionless():
u.Unit(0.1).to_string("vounit")


@pytest.mark.xfail(reason="regression test that reveals a bug")
def test_deprecated_did_you_mean_units():
with pytest.raises(ValueError) as exc_info:
u.Unit("ANGSTROM", format="fits")
Expand All @@ -735,9 +753,8 @@ def test_deprecated_did_you_mean_units():
):
u.Unit("ANGSTROM", format="vounit")

with pytest.warns(UnitsWarning, match=r".* 0\.1nm\.") as w:
with pytest.raises(ValueError, match=r".* 0\.1nm\."):
u.Unit("angstrom", format="vounit")
assert len(w) == 1


@pytest.mark.parametrize("string", ["mag(ct/s)", "dB(mW)", "dex(cm s**-2)"])
Expand Down