clarify test_against_hor2eq and add no atmosphere version - #4870
Merged
Merged
Conversation
Member
|
👍 (Also, I don't know if by now this test is still useful. If no, feel free to remove it completely.) |
Member
Author
|
Definitely still useful! The more cross-checks the better. The coordinate-benchmarks repo is good for more complete testing, but I still think it's worth keeping these in to watch for unintended changes in the core itself. (And the failure is a red herring due to internet hiccups) |
Member
Author
|
Pretty non-controversial, so I'll just go ahead and merge this. Thanks for looking, @cdeil! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at #4436 I happened upon a note in
test_against_hor2eqthat expressed some confusion about differences from the IDL AltAz<->RA/Dec test. That led me to realize that almost all of the difference was due to atmosphere assumptions, so I'm just cleaning up the test to make that more apparent.cc @cdeil as I think the original author of this test (or at least that part of it)